Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guarantee granted always come in the right order #140

Merged
merged 2 commits into from
Aug 7, 2017
Merged

Guarantee granted always come in the right order #140

merged 2 commits into from
Aug 7, 2017

Conversation

mcollina
Copy link
Collaborator

@mcollina mcollina commented Jul 21, 2017 •
edited
Loading

Fixes #133

@mcollina mcollina changed the title failing test for wrong granted order Guarantee granted always come in the right order Aug 7, 2017
@mcollina
Copy link
Collaborator Author

mcollina commented Aug 7, 2017

@behrad I have reverted 607d99d.
So the tests here are passing. I'm releasing this as soon Travis is green. Feel free to send another PR that switches them back to parallel, but it does not break this additional test.

@coveralls
Copy link

coveralls commented Aug 7, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.35% when pulling 25ec7dd on ordered-granted into dc300b9 on master.

@mcollina mcollina merged commit e4b2259 into master Aug 7, 2017
@mcollina mcollina deleted the ordered-granted branch August 7, 2017 07:59
@behrad behrad mentioned this pull request Aug 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcollina @coveralls